ignore imports from vsc namespace made from pkgutil.py #3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
approved these changes
Dec 11, 2019
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Visually it looks fine to me, not sure how to test it though.
Member
Author
|
@ocaisa The enhanced test covers it quite well though. |
Member
|
Ah sorry, I didn't see the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fake
vscPython package that is put in place aftervsc-basewas ingested (see #2790) apparently gets tripped bypkgutil(part of Python standard library) in some situations (probably when avsc-baseis installed system-wide), see https://lists.ugent.be/wws/arc/easybuild/2019-12/msg00044.html.There's no point in exiting with an error in that case, so let's ignore imports from
vsctriggered bypkgutil.py...