Skip to content

make bootstrap script work with Python 3 #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Feb 10, 2020
Merged

make bootstrap script work with Python 3 #3186

boegel merged 1 commit into from
Feb 10, 2020

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 3, 2020 •
edited by boegel
Loading

Minor changes to make bootstrapping EB with Python 3 possible.

  • vsc-* modules are not installed with Python 3 as they are incompatible and also included with EB 4.x
  • With Python 3 EB >=4 is requested and a forced version < 4 is disallowed
  • Python 3.5 is set as the minimum version as this is what is tested on CI

edit: fixes #3027

houndci-bot
houndci-bot reviewed Feb 3, 2020
View reviewed changes
houndci-bot
houndci-bot reviewed Feb 3, 2020
View reviewed changes
@Flamefire Flamefire mentioned this pull request Feb 3, 2020
Closed
ocaisa
ocaisa reviewed Feb 6, 2020
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I tested this and it works fine on with Python3 on Ubuntu 18.04 but better that you merge this one

@ocaisa ocaisa mentioned this pull request Feb 8, 2020
Merged
@boegel boegel changed the title Make bootstrap_eb work with Python 3 make boostrap script work with Python 3 Feb 10, 2020
@boegel boegel added the bug fix label Feb 10, 2020
@boegel boegel added this to the next release (4.1.2?) milestone Feb 10, 2020
@boegel
Copy link
Member

boegel commented Feb 10, 2020

Thanks a lot for your efforts on this @Flamefire, looks great, and the testing of the bootstrap script in CI shows that it works now with Python 3.5+ as well, so merging it...

boegel
boegel approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 19f88d3 into easybuilders:develop Feb 10, 2020
@Flamefire Flamefire deleted the bootstrap_with_py3 branch February 10, 2020 13:50
@boegel boegel changed the title make boostrap script work with Python 3 make bootstrap script work with Python 3 Feb 10, 2020
@boegel boegel added the python3 Python 3 compatibility label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa left review comments

@boegel boegel boegel approved these changes

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix python3 Python 3 compatibility

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

Bootstrap script incompatible with python3

4 participants

@Flamefire @boegel @ocaisa @houndci-bot