Skip to content

Add template for mpi_cmd_prefix #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 4, 2020
Merged

Add template for mpi_cmd_prefix #3264

merged 10 commits into from
Apr 4, 2020

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Mar 30, 2020

Replaces #3259

@ocaisa ocaisa mentioned this pull request Mar 30, 2020
Closed
@easybuilders easybuilders deleted a comment from boegelbot Mar 30, 2020
@boegel boegel mentioned this pull request Mar 31, 2020
Merged
boegel
boegel requested changes Mar 31, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocaisa This is worth a test for the use of %(mpi_cmd_prefix)s too.

Most remarks tackled & more tests added in ocaisa#45

@boegel boegel mentioned this pull request Mar 31, 2020
Merged
@boegel boegel added this to the release after 4.2.0 (4.2.1?) milestone Mar 31, 2020
ocaisa and others added 3 commits March 31, 2020 20:49
Merge pull request #45 from boegel/mpi_exec_template
1e7fb71 
cleanup, changes + more tests for mpi_cmd_{for,prefix} and %(mpi_cmd_prefix)s
Appease the hound
c6b0048
@boegel
determine initial set of template values without passing Toolchain in…
7aab622 
…stance, roll back workaround in test_resolve_dependencies_minimal w.r.t. use of %(version_minor)s template to define toolchain version
@boegel boegel force-pushed the mpi_exec_template branch from e763c30 to 7aab622 Compare April 1, 2020 18:13
@boegel boegel merged commit 92302c0 into easybuilders:develop Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ocaisa @boegel