Skip to content

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented May 24, 2020

(created using eb --new-pr)

#3344 introduces a bug for easyconfigs that depend on the Java wrapper. A dep of Java 11 does not have a minver, so the tests fail (e.g. a bunch of the test failures in easybuilders/easybuild-easyconfigs#10674).

@branfosj branfosj changed the title fix bug when dep is Java wrapper Do not try to set *minver when the dep does not have one - i.e. the Java wrapper May 25, 2020
@easybuilders easybuilders deleted a comment from boegelbot May 25, 2020
enhance test to check that there's no 'javaminver' template if there is no minor version
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 1301bcb into easybuilders:develop May 25, 2020
@boegel boegel added the bug fix label May 25, 2020
@boegel boegel added this to the next release (4.2.2?) milestone May 25, 2020
@branfosj branfosj deleted the 20200524203105_new_pr_vFjjVRikcW branch May 25, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants