take into account multiple easyblock PRs when uploading test reports #3481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@migueldiascosta Can we cover this fix in the tests? |
Member
|
I overlooked that this was a follow-up to #3480, already covered well enough in the tests, so going in, thanks @migueldiascosta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #3480
when used with --from-pr, it simply lists the multiple easyblocks in the comment (e.g. easybuilders/easybuild-easyconfigs#11489 (comment))
when used without --from-pr and with multiple easyblock PRs, this leads to some duplication (e.g. easybuilders/easybuild-easyblocks#2191 (comment), easybuilders/easybuild-easyblocks#2205 (comment)), these comments should probably only list the easyconfigs related to the easyblocks in each PR...