Skip to content

cache result of fetch_files_from_pr function #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
migueldiascosta merged 6 commits into from
Nov 3, 2020
Merged

cache result of fetch_files_from_pr function #3484

migueldiascosta merged 6 commits into from
Nov 3, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Oct 25, 2020

mostly done to speed up the test suite (in the context of #3482)

@boegel boegel added this to the 4.x milestone Oct 25, 2020
@boegel boegel mentioned this pull request Oct 25, 2020
Merged
4 tasks
@boegel boegel modified the milestones: 4.x, 4.3.2 Oct 25, 2020
migueldiascosta
migueldiascosta reviewed Oct 29, 2020
View reviewed changes
akesandgren
akesandgren requested changes Oct 30, 2020
View reviewed changes
akesandgren
akesandgren approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

migueldiascosta
migueldiascosta approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

migueldiascosta commented Nov 3, 2020

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 9c396bf into easybuilders:develop Nov 3, 2020
@boegel boegel deleted the fetch_files_from_pr_cache branch November 3, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

enhancement performance

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @migueldiascosta @akesandgren