add locate_files function to filetools module #3485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
akesandgren
requested changes
Oct 30, 2020
Comment on lines
+795
to
+798
| def locate_files(files, paths, ignore_subdirs=None): | ||
| """ | ||
| Determine full path for list of files, in given list of paths (directories). | ||
| """ |
Contributor
There was a problem hiding this comment.
Since the code seem to be strictly targeted at easyconfig files, the name and description should say so.
Member
Author
There was a problem hiding this comment.
Nothing in this function is specific to easyconfigs. I've renamed the ec_file local variable to filepath, maybe that made you reach that conclusion?
easybuild/tools/filetools.py
Outdated
| # try to load index for current path, or create one | ||
| path_index = load_index(path, ignore_dirs=ignore_subdirs) | ||
| if path_index is None or build_option('ignore_index'): | ||
| if os.path.exists(path): |
Contributor
There was a problem hiding this comment.
This would probably be better to have before the log_debug, i.e. first check if the path exists at all and if not just skip it completely, i.e. "if not os.path.exists(path): next" or however that is done in python
Member
Author
|
@akesandgren Tackled or replied to remarks, please re-review |
Contributor
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.