Skip to content

fix GitHub Actions workflow for test suite: run outside of repo checkout + also test bootstrap script with Python 3.9 #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
migueldiascosta merged 4 commits into from
Dec 4, 2020
Merged

fix GitHub Actions workflow for test suite: run outside of repo checkout + also test bootstrap script with Python 3.9 #3518

migueldiascosta merged 4 commits into from
Dec 4, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 4, 2020

This probably needs to fix from #3517 for the tests to pass...

@boegel boegel added the bug fix label Dec 4, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Dec 4, 2020
bartoldeman
bartoldeman previously approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member Author

boegel commented Dec 4, 2020

I've updated this with the fix from #3517, tests should pass now...

This packaging problem (fixed in #3517) was actually caught in Travis (which is still running the tests with Python 2.6), but not in GitHub Actions, at least not until I made the change I'm making here...

@easybuilders easybuilders deleted a comment from boegelbot Dec 4, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 4, 2020
migueldiascosta
migueldiascosta approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

migueldiascosta commented Dec 4, 2020

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit ae372e0 into easybuilders:develop Dec 4, 2020
@boegel boegel deleted the GA_CI_fixes branch December 5, 2020 08:36
@easybuilders easybuilders deleted a comment from boegelbot Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

@bartoldeman bartoldeman bartoldeman left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @migueldiascosta @bartoldeman