Skip to content

use https for sources.easybuild.io fallback URL #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoldeman merged 1 commit into from
Feb 16, 2021
+3 −3
Merged

use https for sources.easybuild.io fallback URL #3576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
from easybuild.tools.version import this_is_easybuild, VERBOSE_VERSION, VERSION


EASYBUILD_SOURCES_URL = 'http://sources.easybuild.io'
EASYBUILD_SOURCES_URL = 'https://sources.easybuild.io'

MODULE_ONLY_STEPS = [MODULE_STEP, PREPARE_STEP, READY_STEP, POSTITER_STEP, SANITYCHECK_STEP]

Expand Down Expand Up @@ -775,7 +775,7 @@ def obtain_file(self, filename, extension=False, urls=None, download_filename=No
source_urls = []
source_urls.extend(self.cfg['source_urls'])

# add sources.easybuild.io as fallback source URL
# add https://sources.easybuild.io as fallback source URL
source_urls.append(EASYBUILD_SOURCES_URL + '/' + os.path.join(name_letter, self.name))

mkdir(targetdir, parents=True)
Expand Down
2 changes: 1 addition & 1 deletion test/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,7 +1398,7 @@ def test_obtain_file(self):
shutil.rmtree(tmpdir)

def test_fallback_source_url(self):
"""Check whether downloading from fallback source URL http://sources.easybuild.io works."""
"""Check whether downloading from fallback source URL https://sources.easybuild.io works."""
# cfr. https://github.com/easybuilders/easybuild-easyconfigs/issues/11951

init_config(args=["--sourcepath=%s" % self.test_prefix])
Expand Down