Skip to content

Avoid module call for unuse() for Lmod and set $MODULEPATH directly #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Apr 6, 2021

Followup to #3557
No check for priorities is required as LMod correctly handles that
Also adds a check for an empty path which is technically possible and handled by LMod like any other path

Followup to easybuilders#3557
No check for priorities is required as LMod correctly handles that
Also adds a check for an empty path which is technically possible and
handled by LMod like any other path
@easybuilders easybuilders deleted a comment from boegelbot Apr 6, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Avoid module call for unuse() for LMod and set $MODULEPATH directly Avoid module call for unuse() for Lmod and set $MODULEPATH directly Apr 6, 2021
@boegel boegel added this to the next release (4.3.4) milestone Apr 6, 2021
@boegel boegel merged commit b7fcb79 into easybuilders:develop Apr 6, 2021
@Flamefire Flamefire deleted the mlUnuse branch April 6, 2021 15:36
@Flamefire
Copy link
Contributor Author

Followup: #3634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants