Re-enable write permissions when installing with read-only-installdir #3649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows e.g. adding additional packages (e.g. Python). Fixes easybuilders#3033
Flamefire
force-pushed
the
fix_ro_installdir
branch
from
a1b1e47 to
eb7b87f
Compare
This comment has been minimized.
This comment has been minimized.
Flamefire
force-pushed
the
fix_ro_installdir
branch
from
8c5349d to
321e67c
Compare
smoors
reviewed
May 1, 2021
Contributor
smoors
left a comment
smoors
left a comment
There was a problem hiding this comment.
looks good to me, just a small suggestion to change the assert strings
Co-authored-by: Sam Moors <[email protected]>
Contributor
|
Going in, thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows e.g. adding additional packages (e.g. Python).
Fixes #3033