add support for using oneAPI versions of 'intel' toolchain components #3665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (>= iimpi 2020.12)
…1.x in toolchain support
This was referenced Apr 28, 2021
Merged
…native subtoolchain names rather than just one
…s iimpi + make sure correct _set_compiler_vars and set_variables methods are called
boegel
force-pushed
the
oneapi
branch
2 times, most recently
from
cd04da1 to
0da2987
Compare
|
Going in, thanks @boegel! |
This was referenced May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iimpitoolchain definition had to be enhanced to discriminate between the oneAPI generation (iimpiversion 2020.12 and newer), and the "classic" generation. No changes are needed for theinteltoolchain itself (since that just derives fromiimpiand adds MKL).The
det_subtoolchain_versionfunction was enhanced to accept alternative subtoolchain names, since we don't know whetherintel-compilers(for the oneAPI generation) oriccifortis the actual subtoolchain foriimpiuntil we can check the version, which we can't until there's an actual instance of theToochainclass...Other toolchains that use the Intel compilers will need to be tweaked in a similar way, but
iimpiis the more important one in the short term (forintel/2021a).