Skip to content

avoid picking up easyblocks outside of sandbox in framework tests #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented May 16, 2021

fixes #3470

@boegel boegel added the bug fix label May 16, 2021
@boegel boegel added this to the next release (4.4.0) milestone May 16, 2021
@boegel boegel force-pushed the no_external_easyblocks branch 2 times, most recently from df8f092 to 095028c Compare May 16, 2021 13:01
@boegel boegel force-pushed the no_external_easyblocks branch from 095028c to d7b0aec Compare May 16, 2021 17:53
@boegel boegel requested a review from migueldiascosta May 16, 2021 19:35
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and it does fix #3470 for me

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit e977592 into easybuilders:develop May 17, 2021
@boegel boegel deleted the no_external_easyblocks branch May 17, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'easybuild.easyblocks.python' when running include_easyblocks tests with python3
2 participants