Skip to content

add update_build_option function to update specific build options after initializing the EasyBuild configuration #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions easybuild/tools/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,18 @@ def build_option(key, **kwargs):
raise EasyBuildError(error_msg)


def update_build_option(key, value):
"""
Update build option with specified name to given value.

WARNING: Use this with care, the build options are not expected to be changed during an EasyBuild session!
"""
# BuildOptions() is a (singleton) frozen dict, so this is less straightforward that it seems...
build_options = BuildOptions()
build_options._FrozenDict__dict[key] = value
_log.warning("Build option '%s' was updated to: %s", key, build_option(key))


def build_path():
"""
Return the build path
Expand Down
9 changes: 8 additions & 1 deletion test/framework/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from easybuild.tools import run
from easybuild.tools.build_log import EasyBuildError
from easybuild.tools.config import build_option, build_path, get_build_log_path, get_log_filename, get_repositorypath
from easybuild.tools.config import install_path, log_file_format, log_path, source_paths
from easybuild.tools.config import install_path, log_file_format, log_path, source_paths, update_build_option
from easybuild.tools.config import BuildOptions, ConfigurationVariables
from easybuild.tools.config import DEFAULT_PATH_SUBDIRS, init_build_options
from easybuild.tools.filetools import copy_dir, mkdir, write_file
Expand Down Expand Up @@ -677,6 +677,13 @@ def test_get_build_log_path(self):
init_config(args=['--tmp-logdir=%s' % build_log_path])
self.assertEqual(get_build_log_path(), build_log_path)

def test_update_build_option(self):
"""Test updating of a build option."""
self.assertEqual(build_option('banned_linked_shared_libs'), None)

update_build_option('banned_linked_shared_libs', '/usr/lib64/libssl.so.1.1')
self.assertEqual(build_option('banned_linked_shared_libs'), '/usr/lib64/libssl.so.1.1')


def suite():
return TestLoaderFiltered().loadTestsFromTestCase(EasyBuildConfigTest, sys.argv[1:])
Expand Down