enhance sched_getaffinity function to avoid early crash when counting available cores on systems with more than 1024 cores #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically determine the size of the cpu_set_t struct doubling it on each try
|
@Flamefire Can you mention the error/crash you run into without this fix in the PR description? |
|
Added |
akesandgren
reviewed
May 26, 2021
|
Apart from my comment above this code is sane and correct. |
akesandgren
reviewed
May 26, 2021
boegel
changed the title
|
Going in, thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically determine the size of the cpu_set_t struct doubling it on each try
This is basically what the os module in Python 3.3+ does, see e.g. https://github.com/akheron/cpython/blob/f91d2f2e2e992c3006a5023eb4ba3cf0d082fde8/Modules/posixmodule.c#L5706
Error shown even on
eb --helpis: