Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jun 6, 2021

follow-up for #3724

migueldiascosta
migueldiascosta previously approved these changes Jun 7, 2021
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…writing variables outside of list comprehension when using Python 2
migueldiascosta and others added 2 commits June 8, 2021 10:29
… overwriting variables outside of list comprehensions when using Python 2
…e_letter_variables

use even more single-letter variables in list comprehensions to avoid overwriting variables outside of list comprehensions when using Python 2
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Jun 8, 2021

Going in, thanks @boegel!

@smoors smoors merged commit d99c228 into easybuilders:develop Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants