Error out when passing a list to run_cmd* to avoid running wrong command unintended, unless shell=True is used #3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
run_cmd_shell
branch
2 times, most recently
from
726777d to
886741f
Compare
bartoldeman
previously requested changes
Jun 19, 2021
Contributor
bartoldeman
left a comment
bartoldeman
left a comment
There was a problem hiding this comment.
just a little typo to fix, otherwise lgtm
Flamefire
commented
Jun 21, 2021
This is a serious pitfall as e.g. run_cmd(['python', '-c' , 'print(1)']) would be interpreted as `bash -c python -c 'print(1)'`, i.e. the arguments are passed to bash and not to python! Allow to opt-in into that by passing shell=True explicitely.
boegel
changed the title
boegel
changed the title
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a serious pitfall as e.g. run_cmd(['python', '-c' , 'print(1)']) would be interpreted as
bash -c python -c 'print(1)', i.e. the arguments are passed to bash and not to python!Allow to opt-in into that by passing shell=True explicitely.
edit (by @boegel): only occurrence in central easyblocks was in custom easyblock for TensorFlow, which was fixed in easybuilders/easybuild-easyblocks#2469 (I went through all easyblocks, didn't find other instances of passing a list of strings to
run_cmd*)