Skip to content

clarify error message when determining required dependencies for extension fails #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branfosj merged 2 commits into from
Oct 27, 2021
Merged

clarify error message when determining required dependencies for extension fails #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c7a7db
tweak error when Extension.required_deps is not implemented
boegel Oct 26, 2021
3179ddb
remove unused iter_id in EasyBlock.install_extensions_parallel
boegel Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,11 +1754,8 @@ def update_exts_progress_bar_helper(running_exts, progress_size):

self.update_exts_progress_bar(progress_info, progress_size=progress_size)

iter_id = 0
while exts_queue or running_exts:

iter_id += 1

# always go back to original work dir to avoid running stuff from a dir that no longer exists
change_dir(self.orig_workdir)

Expand Down
2 changes: 1 addition & 1 deletion easybuild/framework/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def async_cmd_check(self):
@property
def required_deps(self):
"""Return list of required dependencies for this extension."""
raise NotImplementedError("Don't know how to determine required dependencies for %s" % self.name)
raise NotImplementedError("Don't know how to determine required dependencies for extension '%s'" % self.name)

@property
def toolchain(self):
Expand Down