make check_sha256_checksums verify all checksums if they're specified as a dict value #4076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
force-pushed
the
fix_check_sha256_checksums_dict
branch
from
498df63 to
4ca4a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
easybuilders/easybuild-easyconfigs#16234 showed that
check_sha256_checksumsoverlooks faulty SHA256 checksums, this PR fixes that by checking all checksum values if a checksum is specified as a dict value, not just the checksum one of the possible source filenames (so in the case of CUDA, only for for thex86_64"source" file).