-
Notifications
You must be signed in to change notification settings - Fork 211
fix typo in condition guarding installation of GitHub token in CI workflow to run unit tests + fix broken tests related to GitHub integration features #4216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…kflow to run unit tests
…is also used for write actions
draft PR because for some reason the token provided by GitHub isn't recognized as valid see for example https://github.com/boegel/easybuild-framework/actions/runs/4181752996/jobs/7244026081
|
@migueldiascosta pointed out to me that we're using We should try using the standard |
…thub_* so they can be easily filtered
…t status of old commits is no longer available
…run framework test suite
Broken tests should all be fixed now, and all GitHub tests pass again when a GitHub token is available (most GitHub tests are skipped when no GitHub token is available, when the test suite is run in the scope of a PR for example, like here). See https://github.com/boegel/easybuild-framework/actions/runs/4698932377 for a run where a GitHub token is available and no tests are skipped. I had to go back to provided a self-created GitHub token and make it available to the tests as an encrypted secret, because some tests require that the token has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #4214