Skip to content

enable --trace by default #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 25 commits into from
Jun 22, 2023
Merged

enable --trace by default #4250

boegel merged 25 commits into from
Jun 22, 2023

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented Apr 30, 2023 •
edited
Loading

No description provided.

@branfosj branfosj added the EasyBuild-5.0 EasyBuild 5.0 label Apr 30, 2023
@branfosj branfosj added this to the 5.0 milestone Apr 30, 2023
@branfosj branfosj marked this pull request as draft April 30, 2023 14:17
@branfosj branfosj marked this pull request as draft April 30, 2023 14:17
@branfosj branfosj marked this pull request as draft April 30, 2023 14:17
@branfosj branfosj marked this pull request as draft April 30, 2023 14:17
@branfosj branfosj marked this pull request as draft April 30, 2023 14:17
@boegel boegel changed the title change default for trace to be on enable --trace by default May 3, 2023
@easybuilders easybuilders deleted a comment from boegelbot May 28, 2023
@easybuilders easybuilders deleted a comment from boegelbot May 28, 2023
@easybuilders easybuilders deleted a comment from boegelbot May 28, 2023
@branfosj branfosj marked this pull request as ready for review May 28, 2023 18:55
@easybuilders easybuilders deleted a comment from boegelbot Jun 3, 2023
boegel
boegel approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 22, 2023

Checked the GitHub-related tests, those all pass too, so this is good to go.

Thanks for the effort on this @branfosj!

@boegel boegel merged commit 6abe08f into easybuilders:5.0.x Jun 22, 2023
@branfosj branfosj deleted the trace branch June 22, 2023 12:45
@boegel boegel added the change label Aug 2, 2023
@boegel boegel mentioned this pull request Aug 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change EasyBuild-5.0 EasyBuild 5.0

Projects

No open projects
EasyBuild v5.0
Status: No status

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel