use more performant and concise dict construction by using dict comprehensions #4410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
cleanup-dict
branch
from
c0a208a to
a0ce578
Compare
The pattern `dict([(key, value) for key, value in (construction)])` is
very verbose and creates an intermediate list of tuples.
Replace by `{key: value for key, value in (construction)}` to let Python
core handle it without unncessary intermediates.
Flamefire
force-pushed
the
cleanup-dict
branch
from
5a1637d to
54a56aa
Compare
Flamefire
force-pushed
the
cleanup-dict
branch
3 times, most recently
from
b67d8dc to
cf02d83
Compare
boegel
changed the title
boegel
approved these changes
Apr 3, 2024
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern
dict([(key, value) for key, value in (construction)])is very verbose and creates an intermediate list of tuples. Replace by{key: value for key, value in (construction)}to let Python core handle it without unncessary intermediates.