-
Notifications
You must be signed in to change notification settings - Fork 211
refactor generation of required environment variables in module files + deprecate make_module_req_guess
method in EasyBlock
class
#4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
734cd99
refactor generation of required environment variables in module files
lexming df505cf
update test_make_module_req to add a file into MANPATH of test instal…
lexming 5680038
disable non-empty check on search path drectories for fake module files
lexming 5b17f2e
change position of easyblock methods make_module_req_guess and _expan…
lexming 9205c3b
add new class ModuleEnvironmentVariable to hold definitions of enviro…
lexming 29affc9
add new class ModuleLoadEnvironment to hold environment definition fo…
lexming 8d3a051
add LibSymlink enum to easyblock to define possible states of symlink…
lexming ee37ae7
set library symlink state at the end of post_install_step
lexming b6e1821
use environment definition from ModuleLoadEnvironment in make_module_…
lexming 544a316
deprecate make_module_req_guess in favor of directly using ModuleLoad…
lexming dc09eee
consider both possible symplink states between lib and lib64 in expan…
lexming 562c98d
fix code style around ModuleEnvironmentVariable
lexming 17cc73f
add check_install_lib_symlink method to EasyBlock to be able to trigg…
lexming 16e4743
remove unused empty attribute from ModuleEnvironmentVariable
lexming f68f383
attributes in ModuleLoadEnvironment can only be instances of ModuleEn…
lexming 0b81a21
Merge branch '5.0.x' into cpath-mod
lexming 36d4f92
add test to verify that environment variables don't leak into module …
boegel fa25ae2
Merge pull request #5 from boegel/cpath-mod
lexming 50b9195
Merge branch '5.0.x' into cpath-mod
lexming d560ce2
convert ModuleLoadEnvironment to regular class instead of singleton
lexming 9a230cf
enable raising of errors when running toy build in test_toy_multiple_…
boegel f43ae67
fix test_toy_multiple_ecs_module when using Tcl as module syntax
boegel 0b17167
Merge branch '5.0.x' into cpath-mod
lexming fad0926
fix deprecation warning about make_module_req_guess
lexming 5f04fc3
make ModuleEnvironmentVariable iterable
lexming a45783e
ModuleEnvironmentVariable repr corresponds to its list of paths
lexming b330d84
add update method to ModuleEnvironmentVariable to replace its list of…
lexming c67afd4
add logging facility to ModuleEnvironmentVariable
lexming 6048010
add remove method to ModuleEnvironmentVariable
lexming de3fa38
rename ModuleEnvironmentVariable.paths to ModuleEnvironmentVariable.c…
lexming 0274faf
ensure ModuleEnvironmentVariable is a list of unique strings
lexming 5b4372e
make EasyBlock._expand_module_search_path a public method
lexming f20adb8
fix codestyle issues
lexming 03c6c46
replace make_module_req_guess with module_load_environment in Toy eas…
lexming d43acae
ExtensionEasyBlock pulls module load environment from its master
lexming c692e66
automatically enforce top level files for PATH and LD_LIBRARY_PATH in…
lexming 561d89e
replace make_module_req_guess with module_load_environment in test_ma…
lexming a514a42
allow to customize delimiter in ModuleEnvironmentVariable
lexming 7f96240
rework LibSymlink to make it less confusing
boegel d3fdd71
fix order of import statement from tools.config in easyblock.py
boegel 084467f
make sure that install_lib_symlink always gets set when calling check…
boegel ef446e3
rename 'top_level_file' attribute of ModuleEnvironmentVariable to 're…
boegel f50639d
deprecate EasyBlock.make_module_req_guess method
boegel b38ff58
use 'continue' rather than 'break' in EasyBlock.expand_module_search_…
boegel 7972f2e
minor style changes
boegel a34c33f
Merge pull request #6 from boegel/cpath-mod
lexming 9eaed27
add test_expand_module_search_path to easyblock unit tests
lexming 71d36c8
Merge branch '5.0.x' into cpath-mod
lexming 55ae588
fix typo in EasyBlock.check_install_lib_symlink
lexming f761d34
fix symlink checking in test_expand_module_search_path
lexming 9297094
ModuleLoadEnvironment.environ returns dict with string formatted values
lexming 87afba7
add update and as_dict methods to ModuleLoadEnvironment class
lexming 38774ac
make_module_req updates module_load_environment if a deprecated make_…
lexming 5fb0467
fix codestyle in test.framework.modules
lexming 516d6e6
improve control on ModuleEnvironmentVariable behaviour by adding type…
lexming de961fe
fix codestyle in easybuild.tools.modules
lexming d4a9df0
EasyBlock.expand_module_search_path accepts ModEnvVarType as path_typ…
lexming fcd21b8
require that ModuleLoadEnvironment attributes being set have uppercas…
boegel 2ee964d
fix failures in test_expand_module_search_path by not assuming partic…
boegel f69f23f
make sure that check_install_lib_symlink updates self.install_lib_sym…
boegel d27e1cb
always use ModEnvVarType.PATH_WITH_FILES and ModEnvVarType.PATH_WITH_…
boegel f820358
revert: disable non-empty check on search path drectories for fake mo…
lexming a9e5267
log at debug level the environment targeted by make_module_req before…
lexming 13f735c
fix passing of arguments in ModuleEnvironmentVariable.remove
lexming 87615f0
Merge pull request #7 from boegel/cpath-mod
lexming 678ce99
Revert "fix passing of arguments in ModuleEnvironmentVariable.remove"
lexming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.