Add context manager for allowing unresolved templates and make the state members private + remove support for directly setting enable_templating and expect_resolved_template_values
#4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
resolve-context-manager
branch
from
89baf77 to
1c7bdec
Compare
1 task
This should only be disabled temporarily so make the state private and expose only the context manager and a property.
Only expose the context manager and a property
Allows to use the `resolve` member method that checks for generated values already.
This reverts commit 2a63863.
Flamefire
force-pushed
the
resolve-context-manager
branch
from
1c7bdec to
45196fb
Compare
boegel
approved these changes
Feb 12, 2025
Member
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
lgtm, but I would like to see this tested thoroughly via updated Bundle easyblock in easybuilders/easybuild-easyblocks#3547 before merging it...
Contributor
Author
|
I can do that. Any specific ECs in mind or just 3-4 ones using |
Contributor
Author
|
@boegel Test report using this: easybuilders/easybuild-easyblocks#3547 (comment) |
boegel
requested changes
Feb 24, 2025
…ther than accessing private class variables directly
boegel
changed the title
enable_templating and expect_resolved_template_values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both (templating and disabling the enforcing) should only be disabled temporarily so make the state private and expose only the context manager and a property.
2 small fixes in adjacent code:
resolve_templatemember instead of the free function to remove some C&P codeI also intended to make
asdicttrivial (see 2a63863) but as__getitem__checks for deprecated parameters on each access it might impact performance too much.Improvement after #4726