enhance apply_regex_substitutions to support use of multi-line patterns, requiring matching all patterns in each file, and use pre-compiled regular expressions
#4758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
multi-line-replacement
branch
from
c14b549 to
20826c6
Compare
It might be required to replace patterns with more context, e.g. content of the next or previous line to disambiguate otherwise too generic matches. Add parameter `single_line` to enable the old behavior (default) of matching per line and otherwise match the whole text. Add parameter `match_all` to require all patterns to match for each file not only at least one.
Flamefire
force-pushed
the
multi-line-replacement
branch
2 times, most recently
from
b5fcdce to
9a9d4a3
Compare
Flamefire
force-pushed
the
multi-line-replacement
branch
from
9a9d4a3 to
7e53406
Compare
3 tasks
boegel
changed the title
apply_regex_substitutionsapply_regex_substitutions to support use of multi-line patterns, requiring matching all patterns in each file, and use pre-compiled regular expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be required to replace patterns with more context, e.g. content of the next or previous line to disambiguate otherwise too generic matches.
Add parameter
single_lineto enable the old behavior (default) of matching per line and otherwise match the whole text.Add parameter
match_allto require all patterns to match for each file not only at least one.Also allow to pass regex
Patternobject instead of string patterns to allow for additional flags per pattern.Additionally I collect all error messages for all files and report them together instead of per file for easier resolving.
Note: I set the defaults to be backwards compatible to the current behavior. For EB 5 I'd change
match_allto default toTruewhich is likely the safer default.