Skip to content

correctly deal with easyblocks that still use deprecated make_module_req_guess method: remove environment variables if they're not present in guesses #4763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 13, 2025

Some easyblocks (like Conda, Anaconda, XALT) create an entirely new dict in make_module_req_guess, which we should respect. If that dict doesn't include environment variables like PATH and LD_LIBRARY_PATH, it's for a good reason.

…req_guess method: remove environment variables if they're not present in guesses
@boegel boegel added bug fix EasyBuild-5.0 EasyBuild 5.0 labels Feb 13, 2025
@boegel boegel added this to the 5.0 milestone Feb 13, 2025
@boegel boegel requested a review from lexming February 13, 2025 10:15
@lexming lexming merged commit ebbfe45 into easybuilders:5.0.x Feb 13, 2025
39 checks passed
@boegel boegel deleted the fix_make_module_req_guess branch February 13, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants