add warning about possible checksum verification failure on non-reproducible sources #4798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification of checksums can fail for sources of git repos in non-reproducible format (i.e.
.tar.gz). This is known, but it can be confusing when those fail as there is no clue that this is the reason:Unfortunately, it is not trivial to add specific information in that error, because at that point the knowledge that the failed tarball is from a git repo is already lost.
So this PR adds a big warning message whenever such a tarball is found in the list of sources.