Skip to content

Fix is_patch_for for patch dicts #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Conversation

Flamefire
Copy link
Contributor

The function only handled strings and lists but not the dict patch
format.
This caused a hard error because p % templates doesn't work when p
is a dict --> TypeError.

Factor out function to extract name of patchspec and use it.
This avoids the 2 places where the bug was and simplifies the function.

The function only handled strings and lists but not the dict patch
format.
This caused a hard error because `p % templates` doesn't work when `p`
is a dict --> `TypeError`.

Factor out function to extract name of patchspec and use it.
This avoids the 2 places where the bug was and simplifies the function.
Checking the regular log there is no indication when an easyconfig was
skipped and hence wasn't found for the patch and using `--debug` just
for that produces so much output that it is very hard to find this
single entry.
@boegel boegel added this to the 5.0.1 milestone May 7, 2025
@boegel boegel added the bug fix label May 7, 2025
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented May 13, 2025

Merging, thanks @Flamefire !

@lexming lexming merged commit 4fc1270 into easybuilders:develop May 13, 2025
37 checks passed
@Flamefire Flamefire deleted the fix-patch-for branch May 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants