Skip to content

use develop branch for PRs that target removed 5.0.x branch in fetch_files_from_pr #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

boegel
Copy link
Member

@boegel boegel commented May 16, 2025

The long-lived 5.0.x branch that was used for preparing EasyBuild v5.0.0 was collapsed into the develop branch and removed shortly after the release of EasyBuild v5.0.0.

That causes trouble when --from-pr or --include-easyblocks-from-pr is used on PRs that were targeting the 5.0.x branch, for example:

$ eb --from-pr 22227 -Dr
== Temporary log file in case of crash /tmp/eb-w6t5qm45/easybuild-a07fthw5.log
pr_target_branch='5.0.x'
ERROR: No branch with name 5.0.x found in repo easybuilders/easybuild-easyconfigs: auto_merge_prs, develop, dual_serial_mpi, main, ocaisa-patch-1

Since 5.0.x was collapsed into develop, we can easily fix this by using develop instead

@branfosj branfosj enabled auto-merge May 16, 2025 08:08
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@branfosj branfosj merged commit 8182a62 into easybuilders:develop May 16, 2025
37 checks passed
@boegel boegel deleted the fix_github_tests branch May 16, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants