Skip to content

prefer using importlib.metadata over the deprecated pkg_resources in det_pypkg_version + switch container tests to rockylinux 8.10 #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025

Conversation

boegel
Copy link
Member

@boegel boegel commented May 28, 2025

fixes #4903

@boegel boegel added this to the next release (5.1.1?) milestone May 28, 2025
@boegel boegel added the bug fix label May 28, 2025
@jfgrimm
Copy link
Member

jfgrimm commented May 28, 2025

@boegel any idea why the container tests are failing?

lexming
lexming previously approved these changes May 28, 2025
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@branfosj
Copy link
Member

@boegel any idea why the container tests are failing?

I can reproduce locally...

Last part of the EB log...

== building...
  >> running shell command:
        make  -j 12
        [started at: 2025-05-28 19:04:28]
        [working dir: /scratch/build/M4/1.4.19/system-system/m4-1.4.19]
        [output and state saved to /scratch/tmp/eb-lmgdsutm/run-shell-cmd-output/make-d342nyst]
== ... (took 1 secs)
== FAILED: Installation ended unsuccessfully: shell command 'make ...' failed with exit code 2 in build step for M4-1.4.19.eb (took 40 secs)
== Results of the build can be found in the log file(s) /scratch/tmp/eb-lmgdsutm/easybuild-M4-1.4.19-20250528.190349.UGasO.log
== Summary:
   * [SUCCESS] zlib/1.2.11
   * [FAILED]  M4/1.4.19
   * [SKIPPED] Bison/3.8.2
   * [SKIPPED] flex/2.6.4
   * [SKIPPED] binutils/2.37
   * [SKIPPED] bzip2/1.0.8

@branfosj
Copy link
Member

branfosj commented May 28, 2025

Broken by the changes in easybuilders/easybuild-easyconfigs#22798 with @boegel's comment being the reason. The container tests use Centos 7.

See #4906 for switching to a newer container for the container tests.

@branfosj
Copy link
Member

See #4906 for switching to a newer container for the container tests.

And both this PR and #4906 will need to be in the same PR to avoid both of the sets of test failures that these two PRs fix.

@branfosj
Copy link
Member

@boegel boegel#55 adds the changes from #4906 to this PR to solve the two test suite issues.

switch container tests to rockylinux 8.10
@boegel
Copy link
Member Author

boegel commented May 28, 2025

@boegel boegel#55 adds the changes from #4906 to this PR to solve the two test suite issues.

Merged, thanks for the help with figuring out this one @branfosj!

@branfosj branfosj enabled auto-merge May 28, 2025 20:03
@branfosj branfosj merged commit fea4be0 into easybuilders:develop May 28, 2025
37 checks passed
@boegel boegel changed the title prefer using importlib.metadata over the deprecated pkg_resources in det_pypkg_version prefer using importlib.metadata over the deprecated pkg_resources in det_pypkg_version + switch container tests to rockylinux 8.10 May 28, 2025
@boegel boegel deleted the det_pypkg_version branch May 28, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI triggering pkg_resources deprecation warning in setuptools
4 participants