add back OrderedDict import in (deprecated) easybuild.tools.py2vs3.py3 module
#4965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
OrderedDict import in (deprecated) easybuild.tools.py2vs3.py3 module
Member
|
This fix makes sense, it should be merged as a bug fix (we shouldn't break the API even for deprecated modules like This import was removed via #4607 (so included in EasyBuild 5.0.0), and the |
Contributor
Author
|
I'm rebuilding the modules of EESSI. Using the easyconfigs in the reprod folder failed because of changed or missing easyblocks. So I used the easyblocks from the reprod folders and hit this issue. But then I hit an issue with a missing BLACS easyblock imported by that (older) version of the ScaLAPACK easyblock -.- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still support that deprecated module and some older easyblocks do use it. E.g. the easybuildmeta easyblock in EESSI which fails with