On createBuildConfiguration, reset project's ScannerInfoProvider#817
Conversation
betamaxbandit
force-pushed
the
resetCachedScannerInfoProvider
branch
2 times, most recently
from
1d81b34 to
8415b07
Compare
|
Hi @jonahgraham , Cheers John |
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
The failing tests Code Cleanliness Checks / Test Results (pull_request) are known to fail (since recently) see #816
The Code Cleanliness Checks / build (pull_request) failure is because you reintroduced a deleted project.
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
You have accidentally restored/recreated a project that has been removed from CDT very recently.
There was a problem hiding this comment.
OMG, silly of me.
Removed now.
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
Aside from the small process issues, this is good to go.
| @@ -0,0 +1,121 @@ | |||
| package org.eclipse.cdt.core.build; | |||
betamaxbandit
force-pushed
the
resetCachedScannerInfoProvider
branch
from
8415b07 to
90dc5ff
Compare
betamaxbandit
left a comment
betamaxbandit
left a comment
There was a problem hiding this comment.
@jonahgraham , thanks for your review.
| @@ -0,0 +1,121 @@ | |||
| package org.eclipse.cdt.core.build; | |||
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
OMG, silly of me.
Removed now.
|
Hi @jonahgraham , I pushed an update, but have 3 failing checks now. They say "This job failed". Don't know what I've done or maybe the CI just glitched. Is there a way to rerun? |
When the project's active IBuildConfiguration has the default name and the chosen ICBuildConfigurationProvider.getCBuildConfiguration does not support the IBuildConfiguration.DEFAULT_CONFIG_NAME and returns null, this can cause the project's ScannerInfoProvider to become "stuck" (https://bugs.eclipse.org/bugs/show_bug.cgi?id=413357) on the wrong setting (eg LanguageSettingsScannerInfoProvider instead of ICBuildConfiguration) until Eclipse is restarted or the project is closed and reopened. When this happens, the indexer does not function. This problem may arise if an ISV contributes a ICBuildConfigurationProvider which has very specific naming conventions for it's build configurations. The solution uses the API (resetCachedScannerInfoProvider(project)), introduced by 413357, to reset the project's ScannerInfoProvider when a new ICBuildConfiguration is created.
betamaxbandit
force-pushed
the
resetCachedScannerInfoProvider
branch
from
90dc5ff to
c69a5e0
Compare
|
Hi @jonahgraham , |
It was an error on Github - never seen it before but it said:
As a committer you can press rerun, not sure if contributors can do that. Anyway you figured out the workaround was to just push an update.
Indeed. |
jonahgraham
added
the
backport-to-cdt_11_6
When the project's active IBuildConfiguration has the default name and the chosen ICBuildConfigurationProvider.getCBuildConfiguration does not support the IBuildConfiguration.DEFAULT_CONFIG_NAME and returns null, this can cause the project's ScannerInfoProvider to become "stuck" (https://bugs.eclipse.org/bugs/show_bug.cgi?id=413357) on the wrong setting (eg LanguageSettingsScannerInfoProvider instead of ICBuildConfiguration) until Eclipse is restarted or the project is closed and reopened. When this happens, the indexer does not function. This problem may arise if an ISV contributes a ICBuildConfigurationProvider which has very specific naming conventions for it's build configurations. The solution uses the API (resetCachedScannerInfoProvider(project)), introduced by 413357, to reset the project's ScannerInfoProvider when a new ICBuildConfiguration is created. (cherry picked from commit 0f36d5d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
…ovider (#817) (#854) When the project's active IBuildConfiguration has the default name and the chosen ICBuildConfigurationProvider.getCBuildConfiguration does not support the IBuildConfiguration.DEFAULT_CONFIG_NAME and returns null, this can cause the project's ScannerInfoProvider to become "stuck" (https://bugs.eclipse.org/bugs/show_bug.cgi?id=413357) on the wrong setting (eg LanguageSettingsScannerInfoProvider instead of ICBuildConfiguration) until Eclipse is restarted or the project is closed and reopened. When this happens, the indexer does not function. This problem may arise if an ISV contributes a ICBuildConfigurationProvider which has very specific naming conventions for it's build configurations. The solution uses the API (resetCachedScannerInfoProvider(project)), introduced by 413357, to reset the project's ScannerInfoProvider when a new ICBuildConfiguration is created. (cherry picked from commit 0f36d5d) Co-authored-by: betamax <evil_bandit_betamax@yahoo.co.uk>
2 participants
When the project's active IBuildConfiguration has the default name and the chosen ICBuildConfigurationProvider.getCBuildConfiguration does not support the IBuildConfiguration.DEFAULT_CONFIG_NAME and returns null, this can cause the project's ScannerInfoProvider to become "stuck" (https://bugs.eclipse.org/bugs/show_bug.cgi?id=413357) on the wrong setting (eg LanguageSettingsScannerInfoProvider instead of ICBuildConfiguration) until Eclipse is restarted or the project is closed and reopened. When this happens, the indexer does not function.
This problem may arise if an ISV contributes a
ICBuildConfigurationProvider which has very specific naming conventions for it's build configurations.
The solution uses the API (resetCachedScannerInfoProvider(project)), introduced by 413357, to reset the project's ScannerInfoProvider when a new ICBuildConfiguration is created.