Support for Spring 5 #4062

ankurpathak · 2019-02-18T19:12:07Z

ankurpathak · 2019-02-18T19:14:50Z

Pull request for the issue:
#3736

jansupol · 2019-02-18T19:48:45Z

Please follow the WIKI.

ankurpathak · 2019-02-23T13:30:02Z

@jansupol I can't understand it becoz it uses lot of terms i have never heart and used. Can you please simplify it for this project only like steps I need to do.

jansupol · 2019-02-25T10:14:34Z

@ankurpathak The wiki has it simplified.

commit with -s
Need an Eclipse Account
Need an ECA signed, which is simply done when logged to the account

ankurpathak · 2019-02-26T02:45:56Z

@ankurpathak The wiki has it simplified.

commit with -s

Need an Eclipse Account

Need an ECA signed, which is simply done when logged to the account

@jansupol I signed the commit.

ankurpathak · 2019-03-12T11:46:06Z

@jansupol Can we have faster progress on this issue,??

jansupol · 2019-03-15T09:06:27Z

The files have a wrong license. Some use CDDL/GPL instead of new EPL. The copyright year 2019 should be included, too.

Otherwise, it looks like Spring 4 dependency has just been replaced with Spring 5 and the rest is copied from spring4 module? If so, I'd keep the original starting year in a copyright header and updated only the second year.

It looks good, but we need to file a CQ for Spring 5 first

jansupol · 2019-03-15T10:26:22Z

Created

CQ ~~19278~~ for spring-aop
CQ ~~19280~~ for spring-beans
CQ ~~19277~~ for spring-core
CQ ~~19279~~ for spring-web

ankurpathak · 2019-03-16T06:54:19Z

The files have a wrong license. Some use CDDL/GPL instead of new EPL. The copyright year 2019 should be included, too.

Otherwise, it looks like Spring 4 dependency has just been replaced with Spring 5 and the rest is copied from spring4 module? If so, I'd keep the original starting year in a copyright header and updated only the second year.

It looks good, but we need to file a CQ for Spring 5 first

@jansupol I just brought back the pull request from Old Archived Repository to this repository. Thats the reason it was having issues wth licences. I have fixed the licence to new EPL with orignal start year and new end year as 2019.

ankurpathak · 2019-03-16T06:55:25Z

Created

CQ 19278 for spring-aop

CQ 19280 for spring-beans

CQ 19277 for spring-core

CQ 19279 for spring-web

@jansupol What is CQ? Does I need to do any think related to it for progess of issue?

jansupol · 2019-03-18T10:35:35Z

Regarding the CQs, you do not need to worry about them. They are being processed by legal now.

jansupol · 2019-03-25T15:54:43Z

The CQs were approved

jansupol · 2019-03-26T19:41:56Z

@ankurpathak Should the SpringComponentProvider be modified as described in #4080?

ankurpathak · 2019-03-27T01:38:41Z

@jansupol @snicoll @jhoeller @rwinch @jgrandja I think we can as we have hierachy of contexts possible in Spring. But it will be a great if we take help of someone from spring project here or someone who wrote support for orignal spring4 support. So I am tagging some experts from Spring Projects here with this message. Hello Spring Team, can you please help us to resolve #4080 fast, it will be a great help.

jansupol · 2019-05-21T17:24:06Z

@ankurpathak Can you please update the PR as in #4080?

ankurpathak · 2019-05-21T19:25:51Z

@jansupol Modified PR to include changes of #4080.

senivam · 2019-05-22T11:33:01Z

ext/spring5/src/test/java/org/glassfish/jersey/server/spring/filter/TestFilter.java

@@ -0,0 +1,39 @@
+/*
+ * Copyright (c) 2014, 2018 Oracle and/or its affiliates. All rights reserved.


copyright year is not correct...

@senivam Yes. Its corrected.

senivam · 2019-05-22T11:41:29Z

ext/spring5/src/main/java/org/glassfish/jersey/server/spring/scope/package-info.java

+ */
+
+/**
+ * Jersey server-side Spring 4 integration injection scopes related classes.


Spring 5?

also it would be great to add @ since version here and in other package-info files. Coming version is 2.29

Actually all included package-info.java files have same reference to Spring 4. I suppose it shall be corrected to Spring 5.

@senivam Both package-info.java corrected to Spring 5 and @ since 2.29 added.

Fixes: eclipse-ee4jgh-3736 Signed-off-by: Ankur Pathak <[email protected]>

senivam

LGTM

Signed-off-by: Jan Supol <[email protected]>

ankurpathak mentioned this pull request Feb 18, 2019

Spring 5 support #3736

Closed

jansupol added the Missing Sign-off label Feb 18, 2019

ankurpathak force-pushed the gh-3736-fix branch from 53da848 to 667e1d3 Compare February 26, 2019 02:43

ankurpathak force-pushed the gh-3736-fix branch 3 times, most recently from 268e888 to edd5203 Compare February 26, 2019 09:06

jansupol removed the Missing Sign-off label Feb 28, 2019

jansupol added the CQ required label Mar 15, 2019

ankurpathak force-pushed the gh-3736-fix branch from edd5203 to 7120637 Compare March 16, 2019 06:37

jansupol removed the CQ required label Mar 26, 2019

jansupol mentioned this pull request Mar 26, 2019

Change SpringComponentProvider to look for beans in current and parent application contexts #4080

Merged

ankurpathak mentioned this pull request Mar 27, 2019

Inconsistency in spring-boot-starter-jersey spring-projects/spring-boot#15365

Closed

jansupol added the spring label Mar 29, 2019

ankurpathak force-pushed the gh-3736-fix branch from 7120637 to c7a9187 Compare May 21, 2019 19:24

ankurpathak force-pushed the gh-3736-fix branch from c7a9187 to 2431a3d Compare May 21, 2019 19:39

senivam reviewed May 22, 2019

View reviewed changes

Support for Spring 5

2e915bc

Fixes: eclipse-ee4jgh-3736 Signed-off-by: Ankur Pathak <[email protected]>

ankurpathak force-pushed the gh-3736-fix branch from 2431a3d to 2e915bc Compare May 22, 2019 12:12

senivam approved these changes May 22, 2019

View reviewed changes

Lowered Spring 5 version to a version we have CQ on

f357459

Signed-off-by: Jan Supol <[email protected]>

jansupol force-pushed the gh-3736-fix branch from e883df4 to f357459 Compare May 28, 2019 14:02

jansupol approved these changes May 28, 2019

View reviewed changes

jansupol merged commit 3dca77c into eclipse-ee4j:master May 28, 2019

ankurpathak mentioned this pull request Jul 4, 2019

Fresh Spring Boot Starter Jersey spring-projects/spring-boot#17427

Closed

		@@ -0,0 +1,39 @@
		/*
		* Copyright (c) 2014, 2018 Oracle and/or its affiliates. All rights reserved.

Support for Spring 5 #4062

Support for Spring 5 #4062

Uh oh!

Conversation

ankurpathak commented Feb 18, 2019

Uh oh!

ankurpathak commented Feb 18, 2019

Uh oh!

jansupol commented Feb 18, 2019

Uh oh!

ankurpathak commented Feb 23, 2019

Uh oh!

jansupol commented Feb 25, 2019

Uh oh!

ankurpathak commented Feb 26, 2019

Uh oh!

ankurpathak commented Mar 12, 2019

Uh oh!

jansupol commented Mar 15, 2019

Uh oh!

jansupol commented Mar 15, 2019 • edited by senivam Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ankurpathak commented Mar 16, 2019

Uh oh!

ankurpathak commented Mar 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jansupol commented Mar 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jansupol commented Mar 25, 2019

Uh oh!

jansupol commented Mar 26, 2019

Uh oh!

ankurpathak commented Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jansupol commented May 21, 2019

Uh oh!

ankurpathak commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

senivam May 22, 2019

Choose a reason for hiding this comment

Uh oh!

ankurpathak May 22, 2019

Choose a reason for hiding this comment

Uh oh!

senivam May 22, 2019

Choose a reason for hiding this comment

Uh oh!

ankurpathak May 22, 2019

Choose a reason for hiding this comment

Uh oh!

senivam left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jansupol commented Mar 15, 2019 •

edited by senivam

Loading

ankurpathak commented Mar 16, 2019 •

edited

Loading

jansupol commented Mar 18, 2019 •

edited

Loading

ankurpathak commented Mar 27, 2019 •

edited

Loading

ankurpathak commented May 21, 2019 •

edited

Loading