Allow to use additional properties with security manager/4323 #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…manager is on Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
…rsey Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
senivam
requested changes
Dec 3, 2019
...c/test/java/org/glassfish/jersey/internal/config/SystemPropertiesConfigurationModelTest.java
Show resolved
Hide resolved
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
reviewed
Dec 6, 2019
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
changed the title
senivam
approved these changes
Dec 9, 2019
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
senivam
requested changes
Dec 13, 2019
| assertTrue(properties.containsKey(MultiPartProperties.BUFFER_THRESHOLD)); | ||
| assertTrue(properties.containsKey(OAuth1ServerProperties.ACCESS_TOKEN_URI)); | ||
| } finally { | ||
| System.setSecurityManager(null); |
Contributor
There was a problem hiding this comment.
Or just remove that line? because you are setting securityManager 3 lines below...
| * It doesn't work for higher JDKs because it is using different classloader | ||
| * (jdk.internal.loader.ClassLoaders$AppClassLoader) that current Guava version doesn't support. | ||
| */ | ||
| String version = System.getProperty("java.version"); |
Contributor
There was a problem hiding this comment.
there is JdkVersion class in Jersey which helps to work with versions. Could it be useful here?
|
|
||
| grant { | ||
| permission java.util.PropertyPermission "jersey.config.allowSystemPropertiesProvider", "read"; | ||
| permission java.io.FilePermission "<<ALL FILES>>", "read,write,delete"; |
| return Void.class; | ||
| } | ||
| }); | ||
| for (Predicate<Class<?>> predicate : predicates) { |
Contributor
There was a problem hiding this comment.
since you are already using streams I suppose it would be appropriate to rewrite this FOR cycle with :
.filter(Arrays.stream(predicates).reduce(x->true, Predicate::and))
and then you can just return
.collect(Collectors.toList())
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
Signed-off-by: Jorge Bescos Gascon <[email protected]>
jansupol
approved these changes
Dec 13, 2019
Contributor
jansupol
left a comment
jansupol
left a comment
There was a problem hiding this comment.
Now it looks pretty neat
...n/src/main/java/org/glassfish/jersey/internal/config/SystemPropertiesConfigurationModel.java
Show resolved
Hide resolved
senivam
approved these changes
Dec 17, 2019
1 task
This was referenced Oct 21, 2021
Closed
1 task
1 task
This was referenced Mar 7, 2022
This was referenced Mar 15, 2022
This was referenced Apr 17, 2022
This was referenced May 3, 2022
1 task
1 task
This was referenced Oct 19, 2022
1 task
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to this issue:
#4323
The properties are not loaded by reflection, they are explicitly set in a list. The reason I didn't use reflection is we only want to load jersey properties, so we already know them.
In case we create a new property class and we forget to add it in the list, there is a new test that should fail.