Skip to content

Conversation

@jansupol
Copy link
Contributor

Signed-off-by: jansupol [email protected]

Set<Class<?>> registeredClasses,
InjectionManager injectionManager) {
InjectionManager injectionManager,
Collection<ComponentProvider> componentProviders) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this method is public it is possible that it is already referenced by user code. Shouldn't we duplicate this method with previous arguments?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general contract is that an internal package can be a subject of change. But yes, adding an extra method won't hurt.

@senivam senivam merged commit 7bf9e5d into eclipse-ee4j:master Jan 26, 2021
@jansupol jansupol self-assigned this Jan 26, 2021
@jansupol jansupol added the cdi label Jan 26, 2021
@jansupol jansupol added this to the 2.34 milestone Jan 26, 2021
@jansupol jansupol deleted the cdiOnClient branch January 26, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants