Use caught exception as casue for deployment exception #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the causing exception (if any, `null` otherwise) of the caught exception is set as the cause of a newly created and thrown deployment exception. This effectively removes the causing exception, alongside valuable debugging information. When the stack-trace of the deployment exception is logged, the causing exception is missing from that stack-trace.
Contributor
|
Just an idea, would it be better to replace |
Author
|
I'm not an expert in this code-base, but I'm not sure why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the causing exception (if any,
nullotherwise) of the caught exception is set as the cause of a newly created and thrown deployment exception.This effectively removes the causing exception, alongside valuable debugging information. When the stack-trace of the deployment exception is logged, the causing exception is missing from that stack-trace.