Skip to content

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented May 14, 2025

Drop Guice 3 and Guice 4, make Sisu Guice 5+ (5.1.0+).

Fixes #179

Drop Guice 3 and Guice 4, make Sisu
Guice 5+
@cstamas cstamas requested review from kwin and mcculls May 14, 2025 20:42
@cstamas cstamas self-assigned this May 14, 2025
@sonarqubecloud
Copy link

@cstamas
Copy link
Member Author

cstamas commented May 14, 2025

This is post 1.0.0 release. I'd like to have 1.0.0 "as it is done" by Stuart.
Later we should drop the history (legacy), maybe deprecations as well (org.sonatype package), and maybe try to adopt to jakarta / guice 6 to support both namespaces? That would effectively "lock" Sisu to Guice 6 as it must still support old javax components.

@slachiewicz

This comment was marked as resolved.

@cstamas
Copy link
Member Author

cstamas commented May 17, 2025

As you see, there is no code change, merely dropped tests for 3 and 4. We moved to "newer" versions, that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider narrowing supported Guice versions

3 participants