Merged
Conversation
henrikplate
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is raised to change the standard JDK HttpURLConnection to the Apache Http client. This is done to send keep-alive probes. Changing it to Apache Http Client enables users to configure keep-alive probes by changing OS parameters like net.inet.tcp.keepidle, net.inet.tcp.keepintvl and net.inet.tcp.keepcnt.
Working process of these OS params
Basic testing with vulas:app is done. I also tested 503 scenarios where we do retries.
I am testing more scenarios, meanwhile, you can review the code.