-
Notifications
You must be signed in to change notification settings - Fork 2.7k
vscode: Add support for resolveTreeItem to TreeDataProvider
#11708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: Add support for resolveTreeItem to TreeDataProvider
#11708
Conversation
2cbea66 to
aecffad
Compare
msujew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good! I can confirm that the extension and the new API works as expected.
aecffad to
edfb8ab
Compare
|
@msujew Thank you very much for the review and the suggestions :) I incorporated them and rebased onto the current master. Edit: The 3PP License Check seems to have failed because of a missing access token:
|
@lucas-koehler rebasing the pull-request again should fix the license check errors you encountered thanks to #11770. Does the pull-request ultimately close #11147? (at the moment the issue is not properly linked) |
* Extend `theia.d.ts` with optional method `resolveTreeItem` in `TreeDataProvider` * Add infrastructure on ext side to resolve tree items * Add resolvable tree view node classes * Add resolvement for tooltips and commands * Align TreeViewItem and TreeViewNode tooltip property type to include `MarkdownString` Implements eclipse-theia#11147 Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
edfb8ab to
bed1265
Compare
|
@vince-fugnitto Thanks for the hint. Yes, this closes #11147 . I adapted the PR message accordingly. |
msujew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
- Items are resolved using the API as expected
- Aligns the
TreeDataProviderAPI to the newest version of vscode
What it does
theia.d.tswith optional methodresolveTreeIteminTreeDataProviderMarkdownStringFixes #11147
Contributed on behalf of STMicroelectronics
Signed-off-by: Lucas Koehler [email protected]
How to test
TEST VIEWto the explorer. Theaelement subtree resolves tooltips and commands while thebelement subtree has both given as part of the original tree items.aandbsub(elements): Tooltips should be shown for both.TreeDataProvider-resolveTreeItem.mp4
Review checklist
Reminder for reviewers