Skip to content

feat(clearingHouse): Integrate the Tagus Release V2 Api#1220

Merged
ntruchsess merged 11 commits intoeclipse-tractusx:mainfrom
tfjanjua:chore/1217-gaia-x-tagus-release-update
Feb 6, 2025
Merged

feat(clearingHouse): Integrate the Tagus Release V2 Api#1220
ntruchsess merged 11 commits intoeclipse-tractusx:mainfrom
tfjanjua:chore/1217-gaia-x-tagus-release-update

Conversation

@tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Jan 3, 2025

Description

Integration of the v2 api from Gaia-X Tagus release in company onboarding clearing house.

Why

v1 will be retired as of March 2025. Any API v1 calls will fail with a 400 HTTP Status Code.

Issue

Ref: 1217

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@tfjanjua tfjanjua self-assigned this Jan 3, 2025
@tfjanjua tfjanjua added the enhancement New feature or request label Jan 3, 2025
@evegufy evegufy changed the title chore(clearingHouse): Integrate the Tagus Release V2 Api feat(clearingHouse): Integrate the Tagus Release V2 Api Jan 8, 2025
@tfjanjua tfjanjua marked this pull request as ready for review January 23, 2025 09:48
@tfjanjua tfjanjua requested review from AnuragNagpure, Phil91 and ntruchsess and removed request for Phil91 and ntruchsess January 23, 2025 09:48
@evegufy evegufy added this to the Release 25.03 milestone Jan 23, 2025
@evegufy evegufy requested a review from typecastcloud January 23, 2025 12:43
@Phil91
Copy link
Member

Phil91 commented Jan 31, 2025

@tfjanjua you didn't checked the I have successfully tested my changes locally was that on purpose? Is there a way to test if the changes are working with the new api before merging it?

@ntruchsess ntruchsess self-assigned this Feb 3, 2025
@tfjanjua
Copy link
Contributor Author

tfjanjua commented Feb 3, 2025

@tfjanjua you didn't checked the I have successfully tested my changes locally was that on purpose? Is there a way to test if the changes are working with the new api before merging it?

Hi @Phil91 , thanks for your feedback
Actually I already have tested changes on my local but clearing house cannot access my local as clearing house calls callback url to tell us the validation results but I wanted to test the callback url call also as changes involved in callback url as well so, we have deployed this change into one of our envs. so I could test if clearing house is also able to call callback url and we are also receiving the results and processing it also ... then I will mark this checkbox I have successfully tested my changes locally.

@tfjanjua tfjanjua requested a review from Phil91 February 3, 2025 13:10
@ntruchsess ntruchsess force-pushed the chore/1217-gaia-x-tagus-release-update branch from c17daab to f8d076a Compare February 5, 2025 12:41
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did move the implicit client-side formating from the query to the business-logic adjusting the respective model-classes and unit-tests.
please also see my new review comments (and pull my changes before proceeding)

@tfjanjua tfjanjua requested a review from ntruchsess February 6, 2025 06:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

@ntruchsess ntruchsess merged commit 54fbbe2 into eclipse-tractusx:main Feb 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: USER READY

Development

Successfully merging this pull request may close these issues.

4 participants