feat(auto-setup): adjust provider callbackurl handling#1227
Merged
Conversation
Phil91
force-pushed
the
feature/1175-provider-callback
branch
from
416bfc4 to
0532efd
Compare
Phil91
force-pushed
the
feature/1175-provider-callback
branch
3 times, most recently
from
f5c0f2b to
5df6634
Compare
evegufy
changed the title
evegufy
previously approved these changes
Feb 6, 2025
Contributor
evegufy
left a comment
evegufy
left a comment
There was a problem hiding this comment.
could you please also document this logic in the portal-assets?
ntruchsess
requested changes
Feb 6, 2025
...dministration/Administration.Service/BusinessLogic/SubscriptionConfigurationBusinessLogic.cs
Outdated
Show resolved
Hide resolved
Phil91
force-pushed
the
feature/1175-provider-callback
branch
from
5df6634 to
f586e59
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...on/Administration.Service.Tests/BusinessLogic/SubscriptionConfigurationBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
...on/Administration.Service.Tests/BusinessLogic/SubscriptionConfigurationBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
Phil91
force-pushed
the
feature/1175-provider-callback
branch
from
f586e59 to
e3ced26
Compare
ntruchsess
force-pushed
the
feature/1175-provider-callback
branch
from
1b54c66 to
e5c4392
Compare
ntruchsess
force-pushed
the
feature/1175-provider-callback
branch
from
e5c4392 to
211c795
Compare
|
ntruchsess
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the provider callback url is removed the trigger provider callback steps are set to done and the await auto setup step is created
Why
If a offer subscription process is in progress and the provider callback url is removed by the provider it might occur that the process is stuck since the next step would be to trigger the provider callback, which must not be triggered anymore
Issue
Refs: #1175
Checklist