dev: add simple grid layout to the dev app. save example name at location hash. show schema and uischema#2269
Merged
lucas-koehler merged 2 commits intoFeb 13, 2024
Conversation
…tion hash. show schema and uischema
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for this contribution ❤️ We will take a look soon 👍 |
lucas-koehler
approved these changes
Feb 13, 2024
lucas-koehler
left a comment
lucas-koehler
left a comment
Contributor
There was a problem hiding this comment.
Hi @davewwww , thanks for this great improvement of the dev/example app ❤️ The changes LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i also stored the selected example at the location hash. and i have added the schema and uischema.