Skip to content

Disable auto select in MuiAutocomplete control#2276

Merged
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
lukasf:fix-autoselect
Feb 12, 2024
Merged

Disable auto select in MuiAutocomplete control#2276
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
lukasf:fix-autoselect

Conversation

@lukasf

@lukasf lukasf commented Feb 10, 2024

Copy link
Copy Markdown
Contributor

The MUI Autoselect control currently has a weird behavior, which can easily lead to accidential selections or selection changes, when the user just wants to "light dismiss" the dropdown. See issue #2232.

This PR fixes the irritating behavior by removing the "autoSelect" property.

@netlify

netlify Bot commented Feb 10, 2024

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit d9d929a
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65c74cfc2430830008cfb9bf
😎 Deploy Preview https://deploy-preview-2276--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant

CLAassistant commented Feb 10, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 84.796%. remained the same
when pulling d9d929a on lukasf:fix-autoselect
into 5c6806f on eclipsesource:master.

@lucas-koehler lucas-koehler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@lucas-koehler lucas-koehler merged commit ce541c5 into eclipsesource:master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete control (React MUI) accidentally selects when click outside

4 participants