refactor(sources): migrate grib source off LegacySource#665
Open
frazane wants to merge 3 commits into
Open
Conversation
aaron-hopkinson
previously approved these changes
Jun 16, 2026
aaron-hopkinson
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me - one optional/minor comment.
Thanks for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
gribsource (GribSource) fromLegacySourceonto the modernSourcebase class. First step towards #553.What problem does this change solve?
LegacySourceis an intermediate base, kept for historical reasons, that stores*args/**kwargsand dispatches through a@staticmethod _execute, leaving sources split across two base classes. This movesgribonto the standardSourcecontract — config in__init__, retrieval inexecute_valid_dates— mirroring the siblingGribIndexSource, which already does this with the sameflavour/grid_definitionconfig. Pure refactor: the_executebody moves verbatim, and the base-classexecute_intervals -> execute_valid_datesfallback is unchanged.What issue or task does this change relate to?
Related to #553.
Additional notes
Behaviour-preserving: building the same recipe with the pre- and post-change
grib.pyproduces a bit-identical dataset (data, statistics, coordinates, dates, variables).test_gribpasses unchanged.This change was developed in tandem with AI coding agents.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.