feat!: upgrade to ulmo #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Have you tested it? Do we have to run npm run build manually?
Author
There was a problem hiding this comment.
From the discussion here, it looks like we either have to do it in tutor-mfe or create a new plugin for it. I still have to test these out.
There was a problem hiding this comment.
Let's verify this before the merge. If needed, it should be added in tutor-indigo, no? The brand changes are added via Indigo, so it does not make sense to add it in mfe, unless I am missing some context.
Author
There was a problem hiding this comment.
Yes, that is true for Edly's brand package.
ahmed-arb
force-pushed
the
ahmed-arb/ulmo-upgrade
branch
from
f6c2a4a to
33890a7
Compare
ahmed-arb
force-pushed
the
ahmed-arb/ulmo-upgrade
branch
from
33890a7 to
45404ca
Compare
…ight (#43) * feat: Add Paragon 23 and fix scripts. * fix: Remove unused imports from core.scss. * feat: Replace colours with design token variables. * feat: Add light and dark themes, disable dark SCSS for now. * feat: Replace SCSS variables by CSS variables in dark theme. * feat: Replace mixins with Paragon 23 versions. * feat: Unwrap SCSS loops, to match what is done in Paragon 23. * feat: Remove dark theme and integrate it hackily in the light theme. * fix: Add lost code. * fix: Remove unused core JSON. * feat: Update dist. * fix: Include abstraction-variables.css from Paragon for missing box-shadow combined variables. * fix: Import Bootstrap button mixins instead of whole Paragon core. Add missing imports. * fix: Fix dark section of color.json: remove source and actions, update description. * feat: Import ./build/core/index.css and Paragon button mixins, don’t import Paragon core anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR syncs teak/Indigo's changes with upstream master and adds support for design tokens.
Key Changes
indigo-dark-themeclass on<body>(instead of Paragon 23's theme variant switching)darkbranch incolor.jsonfile to redefine main CSS variables inbody.indigo-dark-themescopeulmo/indigoRelated Ticket: overhangio/tutor-indigo#141
Note
Feedback welcome for future improvements with design tokens and theme variants