Skip to content

Commit 54507f4

Browse files
fix: remove preview sites from allowed embedding pages (overhangio#25)
This is because the preview pages have been migrated to the learning MFE and now do not run on a separate domain
1 parent a5a38a3 commit 54507f4

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- 💥[Improvement] Remove preview sites from allowed embedding pages as the preview page has been migrated to the learning MFE. (by @Danyal-Faheem)

tutorjupyter/templates/jupyter/apps/jupyterhub_config.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
"{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}:8000",
3030
"{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ CMS_HOST }}",
3131
"{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ CMS_HOST }}:8001",
32-
"{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ PREVIEW_LMS_HOST }}",
33-
"{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ PREVIEW_LMS_HOST }}:8000",
3432
]
3533
{% if MFE_HOST is defined %}
3634
frame_ancestors += [

0 commit comments

Comments
 (0)