fix: remove preview sites from allowed embedding pages#25
Merged
Conversation
This is because the preview pages have been migrated to the learning MFE and now do not run on a separate domain
| @@ -0,0 +1 @@ | |||
| - [Improvement] Remove preview sites from allowed embedding pages as the preview page has been migrated to the learning MFE. (by @Danyal-Faheem) No newline at end of file | |||
Contributor
There was a problem hiding this comment.
nit: let's add breaking change 💥 to highlight this is a potentially breaking change
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
Danyal-Faheem
added a commit
to edly-io/tutor-jupyter
that referenced
this pull request
Jun 23, 2025
DawoudSheraz
pushed a commit
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue: overhangio/tutor#1231
This PR is dependent on overhangio/tutor#1238 to be merged first
This is because the preview pages have been migrated to the learning MFE and now do not run on a separate domain.