fix: adjust modal to full viewport layout#54
Merged
djoseph-apphelix merged 2 commits intorelease-ulmofrom Dec 19, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts modal components to use full viewport layouts by modifying CSS rules for selection modals and TinyMCE editor containers. The changes aim to maximize the available screen space for content within modals.
- Adds full viewport height and width styles to selection modals
- Adjusts TinyMCE editor height to fit within the viewport using calculated values
- Modifies modal backdrop positioning
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/editors/sharedComponents/SelectionModal/index.scss | Adds full viewport sizing rules for xl-default modals and adjusts modal backdrop positioning |
| src/editors/containers/ProblemEditor/components/EditProblemView/index.scss | Sets TinyMCE editor height to fill viewport with hardcoded offset calculation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/editors/containers/ProblemEditor/components/EditProblemView/index.scss
Outdated
Show resolved
Hide resolved
src/editors/containers/ProblemEditor/components/EditProblemView/index.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
papphelix
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fullscreen.mp4
Jira