Edited oadp_types.go, moved PrometheusRule to config/.., ran `mak…
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bundle`, `go mod tidy` - Fix `operator-sdk bundle validate ./bundle` `ERRO[0000] Error: Value openshift-adp-controller-manager: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV` - Moved PrometheusRule to config/prometheus, include prometheus in kustomize - `go mod tidy`
eemcmullan
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e bundle
,go mod tidy`Appending minor fixes to openshift#580
operator-sdk bundle validate ./bundleERRO[0000] Error: Value openshift-adp-controller-manager: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSVgo mod tidy@shubham-pampattiwar Generally new bundle manifests should be defined in
config/and everything inbundle/programmatically generated by runningmake bundle.You can double check your
config/is correct byrm -rf bundlemake bundle