-
-
Notifications
You must be signed in to change notification settings - Fork 11
improve regex for links to be more accurate #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 1 1
Lines 75 75
Branches 24 24
=======================================
Hits 73 73
Misses 2 2
Continue to review full report at Codecov.
|
Maybe we can switch to https://github.com/kevva/url-regex since it's really hard to maintain regexp 😂 |
Regex are hard to maintain but this one should be fine. If you want a simple one that doesn't fail then we can match for |
@egoist why haven't you accepted the pull request? |
You can decline and close this pull request if you want I already switched to a local copy of this module that has the problem solved. |
This resolves #3 and also improves the regular expression to match a few more links.